Skip to content

STM32 : correct compilation issue with USE_FULL_ASSERT macro #5698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 20, 2017

Conversation

jeromecoutant
Copy link
Collaborator

Description

Issue comes only when ST HAL macro USE_FULL_ASSERT is enabled

Status

READY

Issue comes only when ST HAL macro USE_FULL_ASSERT is enabled
Issue comes only when ST HAL macro USE_FULL_ASSERT is enabled
Issue comes only when ST HAL macro USE_FULL_ASSERT is enabled
@0xc0170
Copy link
Contributor

0xc0170 commented Dec 13, 2017

/morph build

@@ -442,16 +442,6 @@
* @{
*/
#define COMP_WINDOWMODE_DISABLE (0x00000000U) /*!< Window mode disabled */
#define COMP_WINDOWMODE_ENABLE COMP_CSR_COMPxWNDWEN /*!< Window mode enabled: non inverting input of comparator X (x=2U,4,6U)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a better tracability don't you think we could add instead ?

// Removed for MBED
#if 0 
...
#endif

@@ -2395,8 +2385,7 @@
|| \
(((INPUT) == COMP_NONINVERTINGINPUT_IO1)))

#define IS_COMP_WINDOWMODE(WINDOWMODE) (((WINDOWMODE) == COMP_WINDOWMODE_DISABLE) || \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a comment "Changed for MBED" ? Ideally adding the PR/commit number...

@@ -611,6 +611,8 @@ typedef struct __SPI_HandleTypeDef

#define IS_SPI_CRC_POLYNOMIAL(POLYNOMIAL) (((POLYNOMIAL) >= 0x1U) && ((POLYNOMIAL) <= 0xFFFFU) && (((POLYNOMIAL)&0x1U) != 0U))

#define IS_SPI_DMA_HANDLE(HANDLE) ((HANDLE) != NULL)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a comment "Added for MBED" ? Ideally adding the PR/commit number...

@jeromecoutant
Copy link
Collaborator Author

@bcostm
No, this is not needed as patch comes from next cube version

@mbed-ci
Copy link

mbed-ci commented Dec 13, 2017

Build : SUCCESS

Build number : 693
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5698/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci
Copy link

mbed-ci commented Dec 13, 2017

@mbed-ci
Copy link

mbed-ci commented Dec 14, 2017

@0xc0170 0xc0170 merged commit 897324e into ARMmbed:master Dec 20, 2017
@jeromecoutant jeromecoutant deleted the PR_ST_ASSERT branch December 20, 2017 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants