-
Notifications
You must be signed in to change notification settings - Fork 3k
STM32 : correct compilation issue with USE_FULL_ASSERT macro #5698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Issue comes only when ST HAL macro USE_FULL_ASSERT is enabled
Issue comes only when ST HAL macro USE_FULL_ASSERT is enabled
Issue comes only when ST HAL macro USE_FULL_ASSERT is enabled
/morph build |
@@ -442,16 +442,6 @@ | |||
* @{ | |||
*/ | |||
#define COMP_WINDOWMODE_DISABLE (0x00000000U) /*!< Window mode disabled */ | |||
#define COMP_WINDOWMODE_ENABLE COMP_CSR_COMPxWNDWEN /*!< Window mode enabled: non inverting input of comparator X (x=2U,4,6U) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For a better tracability don't you think we could add instead ?
// Removed for MBED
#if 0
...
#endif
@@ -2395,8 +2385,7 @@ | |||
|| \ | |||
(((INPUT) == COMP_NONINVERTINGINPUT_IO1))) | |||
|
|||
#define IS_COMP_WINDOWMODE(WINDOWMODE) (((WINDOWMODE) == COMP_WINDOWMODE_DISABLE) || \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a comment "Changed for MBED" ? Ideally adding the PR/commit number...
@@ -611,6 +611,8 @@ typedef struct __SPI_HandleTypeDef | |||
|
|||
#define IS_SPI_CRC_POLYNOMIAL(POLYNOMIAL) (((POLYNOMIAL) >= 0x1U) && ((POLYNOMIAL) <= 0xFFFFU) && (((POLYNOMIAL)&0x1U) != 0U)) | |||
|
|||
#define IS_SPI_DMA_HANDLE(HANDLE) ((HANDLE) != NULL) | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a comment "Added for MBED" ? Ideally adding the PR/commit number...
@bcostm |
Build : SUCCESSBuild number : 693 Triggering tests/morph test |
Test : SUCCESSBuild number : 524 |
Exporter Build : SUCCESSBuild number : 338 |
Description
Issue comes only when ST HAL macro USE_FULL_ASSERT is enabled
Status
READY